Checked PSR-1: Basic Coding Standard & Undefined Variable

adm/board_copy_update.php

@@ -14,6 +14,8 @@ $target_subject = isset($_POST['target_subject']) ? trim($_POST['target_subject'
 
 $target_subject = strip_tags(clean_xss_attributes($target_subject));
 
+$file_copy      = array();
+
 if (empty($bo_table)) {
     alert("원본 테이블 정보가 없습니다.");
 }
@@ -37,8 +39,6 @@ $sql = get_table_define($g5['write_prefix'] . $bo_table);
 $sql = str_replace($g5['write_prefix'] . $bo_table, $g5['write_prefix'] . $target_table, $sql);
 sql_query($sql, false);
 
-$file_copy = array();
-
 // 구조만 복사시에는 공지사항 번호는 복사하지 않는다.
 if ($copy_case == 'schema_only') {
     $board['bo_notice'] = '';

adm/board_delete.inc.php

@@ -1,11 +1,18 @@
 <?php
 // board_delete.php , boardgroup_delete.php 에서 include 하는 파일
 
-if (!defined('_GNUBOARD_')) exit;
+ // 개별 페이지 접근 불가
-if (!defined('_BOARD_DELETE_')) exit; // 개별 페이지 접근 불가
+if (!defined('_GNUBOARD_')) {
+    exit;
+}
+if (!defined('_BOARD_DELETE_')) {
+    exit;
+}
 
 // $tmp_bo_table 에는 $bo_table 값을 넘겨주어야 함
-if (!$tmp_bo_table) { return; }
+if (!$tmp_bo_table) {
+    return;
+}
 
 // 게시판 1개는 삭제 불가 (게시판 복사를 위해서)
 //$row = sql_fetch(" select count(*) as cnt from $g5['board_table'] ");
@@ -24,7 +31,7 @@ sql_query(" delete from {$g5['scrap_table']} where bo_table = '{$tmp_bo_table}'
 sql_query(" delete from {$g5['board_file_table']} where bo_table = '{$tmp_bo_table}' ");
 
 // 게시판 테이블 DROP
-sql_query(" drop table {$g5['write_prefix']}{$tmp_bo_table} ", FALSE);
+sql_query(" drop table {$g5['write_prefix']}{$tmp_bo_table} ", false);
 
 // 좋아요 테이블에서 기록 삭제
 sql_query(" delete from {$g5['board_good_table']} where bo_table = '{$tmp_bo_table}' ");

adm/board_form.php

@@ -7,8 +7,9 @@ auth_check_menu($auth, $sub_menu, 'w');
 
 $sql = " select count(*) as cnt from {$g5['group_table']} ";
 $row = sql_fetch($sql);
-if (!$row['cnt'])
+if (!$row['cnt']) {
     alert('게시판그룹이 한개 이상 생성되어야 합니다.', './boardgroup_form.php');
+}
 
 $html_title = '게시판';
 
@@ -142,7 +143,6 @@ $readonly = "";
 $sound_only = "";
 $required_valid = "";
 if ($w == '') {
-
     $html_title .= ' 생성';
 
     $required = 'required';
@@ -179,21 +179,20 @@ if ($w == '') {
     $board['bo_use_secret'] = 0;
     $board['bo_include_head'] = '_head.php';
     $board['bo_include_tail'] = '_tail.php';
-
 } elseif ($w == 'u') {
-
     $html_title .= ' 수정';
 
-    if (!$board['bo_table'])
+    if (!$board['bo_table']) {
         alert('존재하지 않은 게시판 입니다.');
+    }
 
     if ($is_admin == 'group') {
-        if ($member['mb_id'] != $group['gr_admin'])
+        if ($member['mb_id'] != $group['gr_admin']) {
             alert('그룹이 틀립니다.');
         }
+    }
 
     $readonly = 'readonly';
-
 }
 
 if ($is_admin != 'super') {
@@ -253,7 +252,9 @@ $pg_anchor = '<ul class="anchor">
             <th scope="row"><label for="gr_id">그룹<strong class="sound_only">필수</strong></label></th>
             <td colspan="2">
                 <?php echo get_group_select('gr_id', $board['gr_id'], 'required'); ?>
-                <?php if ($w=='u') { ?><a href="javascript:document.location.href='./board_list.php?sfl=a.gr_id&stx='+document.fboardform.gr_id.value;" class="btn_frmline">동일그룹 게시판목록</a><?php } ?>
+                <?php if ($w=='u') { ?>
+                    <a href="javascript:document.location.href='./board_list.php?sfl=a.gr_id&stx='+document.fboardform.gr_id.value;" class="btn_frmline">동일그룹 게시판목록</a>
+                <?php } ?>
             </td>
         </tr>
         <tr>
@@ -548,7 +549,9 @@ $pg_anchor = '<ul class="anchor">
                 <?php
                 $arr = get_skin_dir('', G5_EDITOR_PATH);
                 for ($i=0; $i<count($arr); $i++) {
-                    if ($i == 0) echo "<option value=\"\">기본환경설정의 에디터 사용</option>";
+                    if ($i == 0) {
+                        echo "<option value=\"\">기본환경설정의 에디터 사용</option>";
+                    }
                     echo "<option value=\"".$arr[$i]."\"".get_selected($board['bo_select_editor'], $arr[$i]).">".$arr[$i]."</option>\n";
                 }
                 ?>
@@ -1193,7 +1196,6 @@ $pg_anchor = '<ul class="anchor">
                 <?php echo help('리스트에서 기본으로 정렬에 사용할 필드를 선택합니다. "기본"으로 사용하지 않으시는 경우 속도가 느려질 수 있습니다.') ?>
                 <select id="bo_sort_field" name="bo_sort_field">
                     <?php foreach (get_board_sort_fields($board) as $v) {
-                        
                         $option_value = $order_by_str = $v[0];
                         if ($v[0] === 'wr_num, wr_reply') {
                             $selected = (! $board['bo_sort_field']) ? 'selected="selected"' : '';

adm/board_form_update.php

@@ -2,22 +2,31 @@
 $sub_menu = "300100";
 include_once('./_common.php');
 
-if ($w == 'u')
+if ($w == 'u') {
     check_demo();
+}
 
 auth_check_menu($auth, $sub_menu, 'w');
 
 check_admin_token();
 
-$gr_id = isset($_POST['gr_id']) ? preg_replace('/[^a-z0-9_]/i', '', $_POST['gr_id']) : '';
+$gr_id              = isset($_POST['gr_id']) ? preg_replace('/[^a-z0-9_]/i', '', (string)$_POST['gr_id']) : '';
 $bo_admin           = isset($_POST['bo_admin']) ? preg_replace('/[^a-z0-9_\, \|\#]/i', '', $_POST['bo_admin']) : '';
 $bo_subject         = isset($_POST['bo_subject']) ? strip_tags(clean_xss_attributes($_POST['bo_subject'])) : '';
 $bo_mobile_subject  = isset($_POST['bo_mobile_subject']) ? strip_tags(clean_xss_attributes($_POST['bo_mobile_subject'])) : '';
 
-if (!$gr_id) { alert('그룹 ID는 반드시 선택하세요.'); }
+if (!$gr_id) {
-if (!$bo_table) { alert('게시판 TABLE명은 반드시 입력하세요.'); }
+    alert('그룹 ID는 반드시 선택하세요.');
-if (!preg_match("/^([A-Za-z0-9_]{1,20})$/", $bo_table)) { alert('게시판 TABLE명은 공백없이 영문자, 숫자, _ 만 사용 가능합니다. (20자 이내)'); }
+}
-if (!$bo_subject) { alert('게시판 제목을 입력하세요.'); }
+if (!$bo_table) {
+    alert('게시판 TABLE명은 반드시 입력하세요.');
+}
+if (!preg_match("/^([A-Za-z0-9_]{1,20})$/", $bo_table)) {
+    alert('게시판 TABLE명은 공백없이 영문자, 숫자, _ 만 사용 가능합니다. (20자 이내)');
+}
+if (!$bo_subject) {
+    alert('게시판 제목을 입력하세요.');
+}
 
 // 게시판명이 금지된 단어로 되어 있으면
 if ($w == '' && in_array($bo_table, get_bo_table_banned_word())) {
@@ -84,7 +93,7 @@ $src_char = array('&', '=');
 $dst_char = array('＆', '〓');
 $bo_category_list = isset($_POST['bo_category_list']) ? str_replace($src_char, $dst_char, $_POST['bo_category_list']) : '';
 //https://github.com/gnuboard/gnuboard5/commit/f5f4925d4eb28ba1af728e1065fc2bdd9ce1da58 에 따른 조치
-$str_bo_category_list = preg_replace("/[\<\>\'\"\\\'\\\"\%\=\(\)\/\^\*]/", "", $bo_category_list);
+$str_bo_category_list = preg_replace("/[\<\>\'\"\\\'\\\"\%\=\(\)\/\^\*]/", "", (string)$bo_category_list);
 
 $bo_use_category = isset($_POST['bo_use_category']) ? (int) $_POST['bo_use_category'] : 0;
 $bo_use_sideview = isset($_POST['bo_use_sideview']) ? (int) $_POST['bo_use_sideview'] : 0;
@@ -260,10 +269,10 @@ $sql_common .= " bo_insert_content   = '{$bo_insert_content}',
                 bo_10               = '{$bo_10}' ";
 
 if ($w == '') {
-
     $row = sql_fetch(" select count(*) as cnt from {$g5['board_table']} where bo_table = '{$bo_table}' ");
-    if ($row['cnt'])
+    if ($row['cnt']) {
         alert($bo_table.' 은(는) 이미 존재하는 TABLE 입니다.');
+    }
 
     $sql = " insert into {$g5['board_table']}
                 set bo_table = '{$bo_table}',
@@ -284,10 +293,8 @@ if ($w == '') {
     $source = array('/__TABLE_NAME__/', '/;/');
     $target = array($create_table, '');
     $sql = preg_replace($source, $target, $sql);
-    sql_query($sql, FALSE);
+    sql_query($sql, false);
-
 } elseif ($w == 'u') {
-
     // 게시판의 글 수
     $sql = " select count(*) as cnt from {$g5['write_prefix']}{$bo_table} where wr_is_comment = 0 ";
     $row = sql_fetch($sql);
@@ -327,8 +334,7 @@ if ($w == '') {
         for ($i=0; $i<count($tmp_array); $i++) {
             $tmp_wr_id = trim($tmp_array[$i]);
             $row = sql_fetch(" select count(*) as cnt from {$g5['write_prefix']}{$bo_table} where wr_id = '{$tmp_wr_id}' ");
-            if ($row['cnt'])
+            if ($row['cnt']) {
-            {
                 $bo_notice .= $lf . $tmp_wr_id;
                 $lf = ",";
             }
@@ -342,7 +348,6 @@ if ($w == '') {
                     {$sql_common}
               where bo_table = '{$bo_table}' ";
     sql_query($sql);
-
 }
 
 
@@ -527,8 +532,9 @@ if ($all_fields) {
 
 delete_cache_latest($bo_table);
 
-if(function_exists('get_admin_captcha_by'))
+if (function_exists('get_admin_captcha_by')) {
     get_admin_captcha_by('remove');
+}
 
 run_event('admin_board_form_update', $bo_table, $w);
 

adm/board_list.php

@@ -40,7 +40,9 @@ $total_count = $row['cnt'];
 
 $rows = $config['cf_page_rows'];
 $total_page  = ceil($total_count / $rows);  // 전체 페이지 계산
-if ($page < 1) { $page = 1; } // 페이지가 없으면 첫 페이지 (1 페이지)
+if ($page < 1) {
+    $page = 1; // 페이지가 없으면 첫 페이지 (1 페이지)
+}
 $from_record = ($page - 1) * $rows; // 시작 열을 구함
 
 $sql = " select * {$sql_common} {$sql_search} {$sql_order} limit {$from_record}, {$rows} ";
@@ -60,7 +62,6 @@ $colspan = 15;
 </div>
 
 <form name="fsearch" id="fsearch" class="local_sch01 local_sch" method="get">
-
 <label for="sfl" class="sound_only">검색대상</label>
 <select name="sfl" id="sfl">
     <option value="bo_table"<?php echo get_selected($sfl, "bo_table", true); ?>>TABLE</option>
@@ -70,11 +71,8 @@ $colspan = 15;
 <label for="stx" class="sound_only">검색어<strong class="sound_only"> 필수</strong></label>
 <input type="text" name="stx" value="<?php echo $stx ?>" id="stx" required class="required frm_input">
 <input type="submit" value="검색" class="btn_submit">
-
 </form>
 
-
-
 <form name="fboardlist" id="fboardlist" action="./board_list_update.php" onsubmit="return fboardlist_submit(this);" method="post">
 <input type="hidden" name="sst" value="<?php echo $sst ?>">
 <input type="hidden" name="sod" value="<?php echo $sod ?>">
@@ -188,8 +186,9 @@ $colspan = 15;
     </tr>
     <?php
     }
-    if ($i == 0)
+    if ($i == 0) {
         echo '<tr><td colspan="'.$colspan.'" class="empty_table">자료가 없습니다.</td></tr>';
+    }
     ?>
     </tbody>
     </table>
@@ -199,8 +198,6 @@ $colspan = 15;
     <input type="submit" name="act_button" value="선택수정" onclick="document.pressed=this.value" class="btn_02 btn">
     <?php if ($is_admin == 'super') { ?>
     <input type="submit" name="act_button" value="선택삭제" onclick="document.pressed=this.value" class="btn_02 btn">
-    <?php } ?>
-    <?php if ($is_admin == 'super') { ?>
     <a href="./board_form.php" id="bo_add" class="btn_01 btn">게시판 추가</a>
     <?php } ?>
 </div>

adm/board_list_update.php

@@ -16,11 +16,9 @@ if (! $post_count_chk) {
 check_admin_token();
 
 if ($act_button === "선택수정") {
-
     auth_check_menu($auth, $sub_menu, 'w');
 
     for ($i=0; $i<$post_count_chk; $i++) {
-
         // 실제 번호를 넘김
         $k = isset($_POST['chk'][$i]) ? (int) $_POST['chk'][$i] : 0;
 
@@ -43,9 +41,10 @@ if ($act_button === "선택수정") {
                         and a.gr_id = b.gr_id
                         and b.gr_admin = '{$member['mb_id']}' ";
             $row = sql_fetch($sql);
-            if (!$row['cnt'])
+            if (!$row['cnt']) {
                 alert('최고관리자가 아닌 경우 다른 관리자의 게시판('.$board_table[$k].')은 수정이 불가합니다.');
             }
+        }
 
         $p_bo_subject = is_array($_POST['bo_subject']) ? strip_tags(clean_xss_attributes($_POST['bo_subject'][$k])) : '';
 
@@ -66,15 +65,17 @@ if ($act_button === "선택수정") {
 
         sql_query($sql);
     }
-
 } elseif ($act_button === "선택삭제") {
-
+    if ($is_admin != 'super') {
-    if ($is_admin != 'super')
         alert('게시판 삭제는 최고관리자만 가능합니다.');
+    }
 
     auth_check_menu($auth, $sub_menu, 'd');
 
     // _BOARD_DELETE_ 상수를 선언해야 board_delete.inc.php 가 정상 작동함
+    /* 확인필요 22.05.27
+    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects,
+    or it should execute logic with side effects, but should not do both.*/
     define('_BOARD_DELETE_', true);
 
     for ($i=0; $i<$post_count_chk; $i++) {
@@ -88,8 +89,6 @@ if ($act_button === "선택수정") {
             include('./board_delete.inc.php');
         }
     }
-
-
 }
 
 run_event('admin_board_list_update', $act_button, $chk, $board_table, $qstr);

adm/board_thumbnail_delete.php

@@ -4,8 +4,9 @@ include_once('./_common.php');
 
 auth_check_menu($auth, $sub_menu, 'w');
 
-if(!$board['bo_table'])
+if (!$board['bo_table']) {
     alert('존재하지 않는 게시판입니다.');
+}
 
 $g5['title'] = $board['bo_subject'].' 게시판 썸네일 삭제';
 include_once('./admin.head.php');
@@ -33,10 +34,11 @@ if(is_dir($dir)) {
 
             flush();
 
-            if ($cnt%10==0)
+            if (($cnt % 10) == 0) {
                 echo PHP_EOL;
             }
         }
+    }
 
     echo '<li>완료됨</li></ul>'.PHP_EOL;
     echo '<div class="local_desc01 local_desc"><p><strong>썸네일 '.$cnt.'건의 삭제 완료됐습니다.</strong></p></div>'.PHP_EOL;

adm/boardgroup_form.php

@@ -4,7 +4,9 @@ include_once('./_common.php');
 
 auth_check_menu($auth, $sub_menu, 'w');
 
-if ($is_admin != 'super' && $w == '') alert('최고관리자만 접근 가능합니다.');
+if ($is_admin != 'super' && $w == '') {
+    alert('최고관리자만 접근 가능합니다.');
+}
 
 $html_title = '게시판그룹';
 $gr_id_attr = '';
@@ -16,23 +18,27 @@ if( ! isset($group['gr_id']) ){
     $group['gr_device'] = '';
 }
 
+$gr = array('gr_use_access' => 0, 'gr_admin'=>'');
 if ($w == '') {
     $gr_id_attr = 'required';
     $sound_only = '<strong class="sound_only"> 필수</strong>';
-    $gr = array('gr_use_access' => 0, 'gr_admin'=>'');
     $html_title .= ' 생성';
 } elseif ($w == 'u') {
     $gr_id_attr = 'readonly';
     $gr = sql_fetch(" select * from {$g5['group_table']} where gr_id = '$gr_id' ");
     $html_title .= ' 수정';
-}
+} else {
-else
     alert('제대로 된 값이 넘어오지 않았습니다.');
+}
 
 if (!isset($group['gr_device'])) {
     sql_query(" ALTER TABLE `{$g5['group_table']}` ADD `gr_device` ENUM('both','pc','mobile') NOT NULL DEFAULT 'both' AFTER `gr_subject` ", false);
 }
 
+// 접근회원수
+$sql1 = " select count(*) as cnt from {$g5['group_member_table']} where gr_id = '{$gr_id}' ";
+$row1 = sql_fetch($sql1);
+$group_member_count = $row1['cnt'];
 
 $g5['title'] = $html_title;
 include_once('./admin.head.php');
@@ -59,10 +65,11 @@ include_once('./admin.head.php');
         <th scope="row"><label for="gr_id">그룹 ID<?php echo $sound_only ?></label></th>
         <td><input type="text" name="gr_id" value="<?php echo $group['gr_id'] ?>" id="gr_id" <?php echo $gr_id_attr; ?> class="<?php echo $gr_id_attr; ?> alnum_ frm_input" maxlength="10">
             <?php
-            if ($w=='')
+            if ($w=='') {
                 echo '영문자, 숫자, _ 만 가능 (공백없이)';
-            else
+            } else {
                 echo '<a href="'.G5_BBS_URL.'/group.php?gr_id='.$group['gr_id'].'" class="btn_frmline">게시판그룹 바로가기</a>';
+            }
             ?>
         </td>
     </tr>
@@ -71,8 +78,9 @@ include_once('./admin.head.php');
         <td>
             <input type="text" name="gr_subject" value="<?php echo get_text($group['gr_subject']) ?>" id="gr_subject" required class="required frm_input" size="80">
             <?php
-            if ($w == 'u')
+            if ($w == 'u') {
                 echo '<a href="./board_form.php?gr_id='.$gr_id.'" class="btn_frmline">게시판생성</a>';
+            }
             ?>
         </td>
     </tr>
@@ -88,13 +96,22 @@ include_once('./admin.head.php');
         </td>
     </tr>
     <tr>
-        <th scope="row"><?php if ($is_admin == 'super') { ?><label for="gr_admin"><?php } ?>그룹 관리자<?php if ($is_admin == 'super') { ?></label><?php } ?></th>
+        <th scope="row">
+        <?php
+        if ($is_admin == 'super') {
+            echo '<label for="gr_admin">그룹 관리자</label>';
+        } else {
+            echo '그룹 관리자';
+        }
+        ?>
+        </th>
         <td>
         <?php
-            if ($is_admin == 'super')
+        if ($is_admin == 'super') {
             echo '<input type="text" id="gr_admin" name="gr_admin" class="frm_input" value="'.$gr['gr_admin'].'" maxlength="20">';
-            else
+        } else {
             echo '<input type="hidden" id="gr_admin" name="gr_admin" value="'.$gr['gr_admin'].'">'.$gr['gr_admin'];
+        }
         ?>
         </td>
     </tr>
@@ -110,10 +127,7 @@ include_once('./admin.head.php');
         <th scope="row">접근회원수</th>
         <td>
         <?php
-            // 접근회원수
+        echo '<a href="./boardgroupmember_list.php?gr_id='.$gr_id.'">'.$group_member_count.'</a>';
-            $sql1 = " select count(*) as cnt from {$g5['group_member_table']} where gr_id = '{$gr_id}' ";
-            $row1 = sql_fetch($sql1);
-            echo '<a href="./boardgroupmember_list.php?gr_id='.$gr_id.'">'.$row1['cnt'].'</a>';
         ?>
         </td>
     </tr>

adm/boardgroup_form_update.php

@@ -2,21 +2,27 @@
 $sub_menu = "300200";
 include_once('./_common.php');
 
-if ($w == 'u')
+if ($w == 'u') {
     check_demo();
+}
 
 auth_check_menu($auth, $sub_menu, 'w');
 
-if ($is_admin != 'super' && $w == '') alert('최고관리자만 접근 가능합니다.');
+if ($is_admin != 'super' && $w == '') {
+    alert('최고관리자만 접근 가능합니다.');
+}
 
 check_admin_token();
 
 $gr_id = isset($_POST['gr_id']) ? $_POST['gr_id'] : '';
 
-if (!preg_match("/^([A-Za-z0-9_]{1,10})$/", $gr_id))
+if (!preg_match("/^([A-Za-z0-9_]{1,10})$/", $gr_id)) {
     alert('그룹 ID는 공백없이 영문자, 숫자, _ 만 사용 가능합니다. (10자 이내)');
+}
 
-if (!$gr_subject) alert('그룹 제목을 입력하세요.');
+if (empty($gr_subject)) {
+    alert('그룹 제목을 입력하세요.');
+}
 
 $posts = array();
 
@@ -62,30 +68,28 @@ $sql_common = " gr_subject = '{$posts['gr_subject']}',
                 gr_8 = '{$posts['gr_8']}',
                 gr_9 = '{$posts['gr_9']}',
                 gr_10 = '{$posts['gr_10']}' ";
-if (isset($_POST['gr_use_access']))
+if (isset($_POST['gr_use_access'])) {
     $sql_common .= ", gr_use_access = '{$_POST['gr_use_access']}' ";
-else
+} else {
     $sql_common .= ", gr_use_access = '' ";
+}
 
 if ($w == '') {
-
     $sql = " select count(*) as cnt from {$g5['group_table']} where gr_id = '{$gr_id}' ";
     $row = sql_fetch($sql);
-    if ($row['cnt'])
+    if ($row['cnt']) {
         alert('이미 존재하는 그룹 ID 입니다.');
+    }
 
     $sql = " insert into {$g5['group_table']}
                 set gr_id = '{$gr_id}',
                      {$sql_common} ";
     sql_query($sql);
-
 } elseif ($w == "u") {
-
     $sql = " update {$g5['group_table']}
                 set {$sql_common}
                 where gr_id = '{$gr_id}' ";
     sql_query($sql);
-
 } else {
     alert('제대로 된 값이 넘어오지 않았습니다.');
 }

adm/boardgroup_list.php

@@ -16,8 +16,9 @@ if (!isset($group['gr_device'])) {
 $sql_common = " from {$g5['group_table']} ";
 
 $sql_search = " where (1) ";
-if ($is_admin != 'super')
+if ($is_admin != 'super') {
     $sql_search .= " and (gr_admin = '{$member['mb_id']}') ";
+}
 
 if ($stx) {
     $sql_search .= " and ( ";
@@ -33,10 +34,11 @@ if ($stx) {
     $sql_search .= " ) ";
 }
 
-if ($sst)
+if ($sst) {
     $sql_order = " order by {$sst} {$sod} ";
-else
+} else {
     $sql_order = " order by gr_id asc ";
+}
 
 $sql = " select count(*) as cnt {$sql_common} {$sql_search} {$sql_order} ";
 $row = sql_fetch($sql);
@@ -44,7 +46,9 @@ $total_count = $row['cnt'];
 
 $rows = $config['cf_page_rows'];
 $total_page  = ceil($total_count / $rows);  // 전체 페이지 계산
-if ($page < 1) $page = 1; // 페이지가 없으면 첫 페이지 (1 페이지)
+if ($page < 1) {
+    $page = 1; // 페이지가 없으면 첫 페이지 (1 페이지)
+}
 $from_record = ($page - 1) * $rows; // 시작 열을 구함
 
 $sql = " select * {$sql_common} {$sql_search} {$sql_order} limit {$from_record}, {$rows} ";
@@ -106,8 +110,7 @@ $colspan = 10;
     </thead>
     <tbody>
     <?php
-    for ($i=0; $row=sql_fetch_array($result); $i++)
+    for ($i=0; $row=sql_fetch_array($result); $i++) {
-    {
         // 접근회원수
         $sql1 = " select count(*) as cnt from {$g5['group_member_table']} where gr_id = '{$row['gr_id']}' ";
         $row1 = sql_fetch($sql1);
@@ -160,11 +163,11 @@ $colspan = 10;
         </td>
         <td class="td_mng td_mng_s"><?php echo $s_upd ?></td>
     </tr>
-
     <?php
     }
-    if ($i == 0)
+    if ($i == 0) {
         echo '<tr><td colspan="'.$colspan.'" class="empty_table">자료가 없습니다.</td></tr>';
+    }
     ?>
     </table>
 </div>

adm/boardgroup_list_update.php

@@ -2,8 +2,6 @@
 $sub_menu = "300200";
 include_once('./_common.php');
 
-//print_r2($_POST); exit;
-
 check_demo();
 
 auth_check_menu($auth, $sub_menu, 'w');
@@ -14,13 +12,13 @@ $post_chk = isset($_POST['chk']) ? (array) $_POST['chk'] : array();
 $post_group_id  = isset($_POST['group_id']) ? (array) $_POST['group_id'] : array();
 $act_button     = isset($_POST['act_button']) ? $_POST['act_button'] : '';
 
-$count = count($post_chk);
+$chk_count = count($post_chk);
 
-if(!$count)
+if (!$chk_count) {
     alert($act_button.'할 게시판그룹을 1개이상 선택해 주세요.');
+}
 
-for ($i=0; $i<$count; $i++)
+for ($i=0; $i<$chk_count; $i++) {
-{
     $k              = isset($post_chk[$i]) ? (int) $post_chk[$i] : 0;
     $gr_id          = preg_replace('/[^a-z0-9_]/i', '', $post_group_id[$k]);
     $gr_subject     = isset($_POST['gr_subject'][$k]) ? strip_tags(clean_xss_attributes($_POST['gr_subject'][$k])) : '';
@@ -37,13 +35,15 @@ for ($i=0; $i<$count; $i++)
                         gr_use_access = '".$gr_use_access."',
                         gr_order      = '".$gr_order."'
                   where gr_id         = '{$gr_id}' ";
-        if ($is_admin != 'super')
+        if ($is_admin != 'super') {
             $sql .= " and gr_admin    = '{$gr_admin}' ";
+        }
         sql_query($sql);
     } elseif ($act_button == '선택삭제') {
         $row = sql_fetch(" select count(*) as cnt from {$g5['board_table']} where gr_id = '$gr_id' ");
-        if ($row['cnt'])
+        if ($row['cnt']) {
             alert("이 그룹에 속한 게시판이 존재하여 게시판 그룹을 삭제할 수 없습니다.\\n\\n이 그룹에 속한 게시판을 먼저 삭제하여 주십시오.", './board_list.php?sfl=gr_id&amp;stx='.$gr_id);
+        }
 
         // 그룹 삭제
         sql_query(" delete from {$g5['group_table']} where gr_id = '$gr_id' ");
@@ -53,6 +53,6 @@ for ($i=0; $i<$count; $i++)
     }
 }
 
-run_event('admin_boardgroup_list_update', $act_button, $chk, $post_group_id, $qstr);
+run_event('admin_boardgroup_list_update', $act_button, $post_chk, $post_group_id, $qstr);
 
 goto_url('./boardgroup_list.php?'.$qstr);

adm/boardgroupmember_form.php

@@ -7,8 +7,9 @@ auth_check_menu($auth, $sub_menu, 'w');
 $mb = get_member($mb_id);
 $token = isset($token) ? $token : '';
  
-if (! (isset($mb['mb_id']) && $mb['mb_id']))
+if (! (isset($mb['mb_id']) && $mb['mb_id'])) {
     alert('존재하지 않는 회원입니다.');
+}
 
 $g5['title'] = '접근가능그룹';
 include_once('./admin.head.php');
@@ -16,16 +17,18 @@ include_once('./admin.head.php');
 $colspan = 4;
 ?>
 
-<form name="fboardgroupmember_form" id="fboardgroupmember_form" action="./boardgroupmember_update.php" onsubmit="return boardgroupmember_form_check(this)" method="post">
+<form name="fboardgroupmember_form" id="fboardgroupmember_form" action="./boardgroupmember_update.php"
+    onsubmit="return boardgroupmember_form_check(this)" method="post">
     <input type="hidden" name="mb_id" value="<?php echo $mb['mb_id'] ?>" id="mb_id">
     <input type="hidden" name="token" value="" id="token">
+
     <div class="local_ov01 local_ov">
         <span class="btn_ov01"><span class="ov_txt"> 아이디</span><span class="ov_num"><?php echo $mb['mb_id'] ?></span></span>
         <span class="btn_ov01"><span class="ov_txt"> 이름</span><span class="ov_num"><?php echo get_text($mb['mb_name']); ?></span></span>
         <span class="btn_ov01"><span class="ov_txt"> 닉네임</span><span class="ov_num"><?php echo $mb['mb_nick'] ?></span></span>
     </div>    
-<div class="local_cmd01 local_cmd">
 
+    <div class="local_cmd01 local_cmd">
         <label for="gr_id">그룹지정</label>
         <select name="gr_id" id="gr_id">
             <option value="">접근가능 그룹을 선택하세요.</option>
@@ -33,9 +36,9 @@ $colspan = 4;
             $sql = " select *
                         from {$g5['group_table']}
                         where gr_use_access = 1 ";
-        //if ($is_admin == 'group') {
+            if ($is_admin != 'super') {
-        if ($is_admin != 'super')
                 $sql .= " and gr_admin = '{$member['mb_id']}' ";
+            }
             $sql .= " order by gr_id ";
             $result = sql_query($sql);
             for ($i=0; $row=sql_fetch_array($result); $i++) {
@@ -47,7 +50,8 @@ $colspan = 4;
     </div>
 </form>
 
-<form name="fboardgroupmember" id="fboardgroupmember" action="./boardgroupmember_update.php" onsubmit="return fboardgroupmember_submit(this);" method="post">
+<form name="fboardgroupmember" id="fboardgroupmember" action="./boardgroupmember_update.php" 
+    onsubmit="return fboardgroupmember_submit(this);" method="post">
     <input type="hidden" name="sst" value="<?php echo $sst ?>" id="sst">
     <input type="hidden" name="sod" value="<?php echo $sod ?>" id="sod">
     <input type="hidden" name="sfl" value="<?php echo $sfl ?>" id="sfl">
@@ -76,8 +80,9 @@ $colspan = 4;
             $sql = " select * from {$g5['group_member_table']} a, {$g5['group_table']} b
                         where a.mb_id = '{$mb['mb_id']}'
                         and a.gr_id = b.gr_id ";
-    if ($is_admin != 'super')
+            if ($is_admin != 'super') {
                 $sql .= " and b.gr_admin = '{$member['mb_id']}' ";
+            }
             $sql .= " order by a.gr_id desc ";
             $result = sql_query($sql);
             for ($i=0; $row=sql_fetch_array($result); $i++) {

adm/boardgroupmember_list.php

@@ -11,8 +11,8 @@ if (!$gr['gr_id']) {
 
 $sql_common = " from {$g5['group_member_table']} a
                          left outer join {$g5['member_table']} b on (a.mb_id = b.mb_id) ";
-
 $sql_search = " where gr_id = '{$gr_id}' ";
+
 // 회원아이디로 검색되지 않던 오류를 수정
 if (isset($stx) && $stx) {
     $sql_search .= " and ( ";
@@ -39,7 +39,9 @@ $total_count = $row['cnt'];
 
 $rows = $config['cf_page_rows'];
 $total_page  = ceil($total_count / $rows);  // 전체 페이지 계산
-if ($page < 1) $page = 1; // 페이지가 없으면 첫 페이지 (1 페이지)
+if ($page < 1) {
+    $page = 1; // 페이지가 없으면 첫 페이지 (1 페이지)
+}
 $from_record = ($page - 1) * $rows; // 시작 열을 구함
 
 $sql = " select *
@@ -66,7 +68,8 @@ $colspan = 7;
     <input type="submit" value="검색" class="btn_submit">
 </form>
 
-<form name="fboardgroupmember" id="fboardgroupmember" action="./boardgroupmember_update.php" onsubmit="return fboardgroupmember_submit(this);" method="post">
+<form name="fboardgroupmember" id="fboardgroupmember" action="./boardgroupmember_update.php" 
+    onsubmit="return fboardgroupmember_submit(this);" method="post">
     <input type="hidden" name="sst" value="<?php echo $sst ?>">
     <input type="hidden" name="sod" value="<?php echo $sod ?>">
     <input type="hidden" name="sfl" value="<?php echo $sfl ?>">
@@ -95,14 +98,14 @@ $colspan = 7;
             </thead>
             <tbody>
             <?php
-    for ($i=0; $row=sql_fetch_array($result); $i++)
+            for ($i=0; $row=sql_fetch_array($result); $i++) {
-    {
                 // 접근가능한 그룹수
                 $sql2 = " select count(*) as cnt from {$g5['group_member_table']} where mb_id = '{$row['mb_id']}' ";
                 $row2 = sql_fetch($sql2);
                 $group = "";
-        if ($row2['cnt'])
+                if ($row2['cnt']) {
                     $group = '<a href="./boardgroupmember_form.php?mb_id='.$row['mb_id'].'">'.$row2['cnt'].'</a>';
+                }
 
                 $mb_nick = get_sideview($row['mb_id'], $row['mb_nick'], $row['mb_email'], $row['mb_homepage']);
 
@@ -123,8 +126,7 @@ $colspan = 7;
                 <?php
             }
 
-    if ($i == 0)
+            if ($i == 0) {
-    {
                 echo '<tr><td colspan="'.$colspan.'" class="empty_table">자료가 없습니다.</td></tr>';
             }
             ?>
@@ -137,7 +139,9 @@ $colspan = 7;
     </div>
 </form>
 
-<?php echo get_paging(G5_IS_MOBILE ? $config['cf_mobile_pages'] : $config['cf_write_pages'], $page, $total_page, "{$_SERVER['SCRIPT_NAME']}?$qstr&amp;gr_id=$gr_id&page="); ?>
+<?php
+echo get_paging(G5_IS_MOBILE ? $config['cf_mobile_pages'] : $config['cf_write_pages'], $page, $total_page, "{$_SERVER['SCRIPT_NAME']}?$qstr&amp;gr_id=$gr_id&page=");
+?>
 
 <script>
 function fboardgroupmember_submit(f)

adm/boardgroupmember_update.php

@@ -4,17 +4,16 @@ include_once('./_common.php');
 
 sql_query(" ALTER TABLE {$g5['group_member_table']} CHANGE `gm_id` `gm_id` INT( 11 ) DEFAULT '0' NOT NULL AUTO_INCREMENT ", false);
 
-if ($w == '')
+if ($w == '') {
-{
     auth_check_menu($auth, $sub_menu, 'w');
 
     $mb = get_member($mb_id);
-    if (!$mb['mb_id']) {
+    if (empty($mb['mb_id'])) {
         alert('존재하지 않는 회원입니다.');
     }
 
     $gr = get_group($gr_id);
-    if (!$gr['gr_id']) {
+    if (empty($gr['gr_id'])) {
         alert('존재하지 않는 그룹입니다.');
     }
 
@@ -25,9 +24,7 @@ if ($w == '')
     $row = sql_fetch($sql);
     if ($row['cnt']) {
         alert('이미 등록되어 있는 자료입니다.');
-    }
+    } else {
-    else
-    {
         check_admin_token();
 
         $sql = " insert into {$g5['group_member_table']}
@@ -36,14 +33,13 @@ if ($w == '')
                          gm_datetime = '".G5_TIME_YMDHIS."' ";
         sql_query($sql);
     }
-}
+} elseif ($w == 'd' || $w == 'ld') {
-else if ($w == 'd' || $w == 'ld')
-{
     auth_check_menu($auth, $sub_menu, 'd');
 
     $count = count($_POST['chk']);
-    if(!$count)
+    if (!$count) {
         alert('삭제할 목록을 하나이상 선택해 주세요.');
+    }
 
     check_admin_token();
 
@@ -52,18 +48,20 @@ else if ($w == 'd' || $w == 'ld')
         $sql = " select * from {$g5['group_member_table']} where gm_id = '$gm_id' ";
         $gm = sql_fetch($sql);
         if (!$gm['gm_id']) {
-            if($count == 1)
+            if ($count == 1) {
                 alert('존재하지 않는 자료입니다.');
-            else
+            } else {
                 continue;
             }
+        }
 
         $sql = " delete from {$g5['group_member_table']} where gm_id = '$gm_id' ";
         sql_query($sql);
     }
 }
 
-if ($w == 'ld')
+if ($w == 'ld') {
     goto_url('./boardgroupmember_list.php?gr_id='.$gr_id);
-else
+} else {
     goto_url('./boardgroupmember_form.php?mb_id='.$mb_id);
+}